From: Arnd Bergmann Date: Tue, 6 Sep 2016 12:54:46 +0000 (+0200) Subject: usb: phy: add USB_SUPPORT dependency X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=cddbc4b7ef39ac5d84f183a46ee279cb0ae31a9f;p=openwrt%2Fstaging%2Fblogic.git usb: phy: add USB_SUPPORT dependency The driver now calls of_usb_get_dr_mode_by_phy, which is part of the USB core layer, and it fails to build when that is not provided: drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy' We already have a couple of other PHY drivers with a dependency on USB_SUPPORT, so that seems to be the easiest fix here. An alternative would be to adjust the #ifdef in include/linux/usb/of.h to also check for CONFIG_USB_SUPPORT. Signed-off-by: Arnd Bergmann Reviewed-by: Hans de Goede Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode") Signed-off-by: Kishon Vijay Abraham I --- diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 1f3e1fbef529..fe00f9134d51 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -267,7 +267,9 @@ config PHY_SUN4I_USB depends on RESET_CONTROLLER depends on EXTCON depends on POWER_SUPPLY + depends on USB_SUPPORT select GENERIC_PHY + select USB_COMMON help Enable this to support the transceiver that is part of Allwinner sunxi SoCs.