From: Hans Verkuil Date: Wed, 10 Apr 2019 09:13:34 +0000 (-0400) Subject: media: cros-ec-cec: decrement HDMI device refcount X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=cea053bed8534cb7de0b2092a246a84e8e512f64;p=openwrt%2Fstaging%2Fblogic.git media: cros-ec-cec: decrement HDMI device refcount The CrosEC CEC driver never decremented the HDMI device refcount. CEC drivers only need the HDMI device pointer as a key in the notifier list, it never accesses the device, so there is no need to keep a reference. Signed-off-by: Hans Verkuil Reviewed-by: Neil Armstrong Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/cros-ec-cec/cros-ec-cec.c b/drivers/media/platform/cros-ec-cec/cros-ec-cec.c index 7bc4d8a9af28..068df9888dbf 100644 --- a/drivers/media/platform/cros-ec-cec/cros-ec-cec.c +++ b/drivers/media/platform/cros-ec-cec/cros-ec-cec.c @@ -236,6 +236,7 @@ static int cros_ec_cec_get_notifier(struct device *dev, return -EPROBE_DEFER; *notify = cec_notifier_get_conn(d, m->conn); + put_device(d); return 0; } }