From: Dmitry Kravkov Date: Wed, 4 Apr 2012 02:27:42 +0000 (+0000) Subject: bnx2x: add missing parenthesis to prevent u32 overflow X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=cfcadc97a890b81f619715739ef101f8c2010e6b;p=openwrt%2Fstaging%2Fblogic.git bnx2x: add missing parenthesis to prevent u32 overflow Commit b475d78 lacked two pairs of parenthesis, causing an overflow in the congestion management. Signed-off-by: Dmitry Kravkov Signed-off-by: Yuval Mintz Signed-off-by: Eilon Greenstein Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h index e6bb9f4c619c..2b7a2bd0592c 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_init.h @@ -409,7 +409,7 @@ static inline void bnx2x_init_min(const struct cmng_init_input *input_data, */ vdata->vnic_min_rate[vnic].vn_credit_delta = (u32)input_data->vnic_min_rate[vnic] * 100 * - T_FAIR_COEF / (8 * 100 * vnicWeightSum); + (T_FAIR_COEF / (8 * 100 * vnicWeightSum)); if (vdata->vnic_min_rate[vnic].vn_credit_delta < pdata->fair_vars.fair_threshold + MIN_ABOVE_THRESH) { @@ -446,7 +446,7 @@ static inline void bnx2x_init_fw_wrr(const struct cmng_init_input *input_data, */ ccd[cos] = (u32)input_data->cos_min_rate[cos] * 100 * - T_FAIR_COEF / (8 * 100 * cosWeightSum); + (T_FAIR_COEF / (8 * 100 * cosWeightSum)); if (ccd[cos] < pdata->fair_vars.fair_threshold + MIN_ABOVE_THRESH) { ccd[cos] =