From: Alexander Couzens Date: Sun, 11 Jun 2017 10:43:24 +0000 (+0200) Subject: ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument `port` X-Git-Tag: v19.07.0-rc1~6278 X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=d18cb142d5dcdf112095d593b60b8c16c74e986b;p=openwrt%2Fstaging%2Fhauke.git ar71xx/ag71xx_ar7240_get_port_link: fix off-by-one check on argument `port` Found-by: Coverity Scan #1329901 Signed-off-by: Alexander Couzens --- diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c index c5aed0d2db..e457acb50c 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ar7240.c @@ -963,7 +963,7 @@ ar7240_get_port_link(struct switch_dev *dev, int port, struct mii_bus *mii = as->mii_bus; u32 status; - if (port > AR7240_NUM_PORTS) + if (port >= AR7240_NUM_PORTS) return -EINVAL; status = ar7240sw_reg_read(mii, AR7240_REG_PORT_STATUS(port)); @@ -1000,7 +1000,7 @@ ar7240_get_port_stats(struct switch_dev *dev, int port, { struct ar7240sw *as = sw_to_ar7240(dev); - if (port > AR7240_NUM_PORTS) + if (port >= AR7240_NUM_PORTS) return -EINVAL; ar7240sw_capture_stats(as);