From: Nick Hainke Date: Mon, 18 Apr 2022 13:04:25 +0000 (+0200) Subject: ipq40xx: 5.10: fix ar40xx driver X-Git-Tag: v22.03.0-rc2~60 X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=d4053d2e8e098c53d6fc6ab860ba71cd8edf5455;p=openwrt%2Fopenwrt.git ipq40xx: 5.10: fix ar40xx driver This commit is completely based on the work of adron-s: https://github.com/openwrt/openwrt/pull/4721#issuecomment-1101108651 The commit fixes the data corruption on TX packets. Packets are transmitted, but their contents are replaced with zeros. This error is caused by the lack of guard (50 ms) intervals between calibration phases. This error is treated by adding mdelay(50) to the calibration function code. In the original qca-ssda code [0], these mdelays were existing, but in the ar41xx.c they are gone. Tested on: - Fritz!Box 4040 - Fritz!Box 7530 - Mikrotik SXTsq 5AC - ZyXEL NBG6617 - [0] https://git.codelinaro.org/clo/qsdk/oss/lklm/qca-ssdk/-/blob/NHSS.QSDK.11.4/src/init/ssdk_init.c#L2072 Suggested-by: Serhii Serhieiev Reviewed-by: Robert Marko Signed-off-by: Nick Hainke (cherry picked from commit ab7e53e5cce703c7a62efbe1d41fb94c2228a178) --- diff --git a/target/linux/ipq40xx/files-5.10/drivers/net/mdio/ar40xx.c b/target/linux/ipq40xx/files-5.10/drivers/net/mdio/ar40xx.c index f7ce42b9ff..d5ef7af151 100644 --- a/target/linux/ipq40xx/files-5.10/drivers/net/mdio/ar40xx.c +++ b/target/linux/ipq40xx/files-5.10/drivers/net/mdio/ar40xx.c @@ -936,6 +936,7 @@ ar40xx_malibu_psgmii_ess_reset(struct ar40xx_priv *priv) */ mdelay(2); } + mdelay(50); /*check malibu psgmii calibration done end..*/ @@ -954,6 +955,7 @@ ar40xx_malibu_psgmii_ess_reset(struct ar40xx_priv *priv) /* Polling interval to check PSGMII PLL in ESS is ready */ mdelay(2); } + mdelay(50); /* check dakota psgmii calibration done end..*/ @@ -961,6 +963,7 @@ ar40xx_malibu_psgmii_ess_reset(struct ar40xx_priv *priv) mdiobus_write(bus, 5, 0x1a, 0x3230); /* release phy psgmii RX 20bit */ mdiobus_write(bus, 5, 0x0, 0x005f); + mdelay(200); } static void