From: Michael Chan Date: Tue, 8 May 2018 07:18:39 +0000 (-0400) Subject: bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only. X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=dac0490718bd17df5e3995ffca14255e5f9ed22d;p=openwrt%2Fstaging%2Fblogic.git bnxt_en: Check unsupported speeds in bnxt_update_link() on PF only. Only non-NPAR PFs need to actively check and manage unsupported link speeds. NPAR functions and VFs do not control the link speed and should skip the unsupported speed detection logic, to avoid warning messages from firmware rejecting the unsupported firmware calls. Signed-off-by: Michael Chan Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 168342ac35c5..cd3ab788936f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -6462,6 +6462,9 @@ static int bnxt_update_link(struct bnxt *bp, bool chng_link_state) } mutex_unlock(&bp->hwrm_cmd_lock); + if (!BNXT_SINGLE_PF(bp)) + return 0; + diff = link_info->support_auto_speeds ^ link_info->advertising; if ((link_info->support_auto_speeds | diff) != link_info->support_auto_speeds) {