From: Jeff Layton Date: Wed, 6 Sep 2017 23:23:19 +0000 (-0700) Subject: fs/sync.c: remove unnecessary NULL f_mapping check in sync_file_range X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=de23abd15175fb170270d485f267caebe86fb0b4;p=openwrt%2Fstaging%2Fblogic.git fs/sync.c: remove unnecessary NULL f_mapping check in sync_file_range fsync codepath assumes that f_mapping can never be NULL, but sync_file_range has a check for that. Remove the one from sync_file_range as I don't see how you'd ever get a NULL pointer in here. Link: http://lkml.kernel.org/r/20170525110509.9434-1-jlayton@redhat.com Signed-off-by: Jeff Layton Cc: Alexander Viro Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/sync.c b/fs/sync.c index 2a54c1f22035..cf57f33fcd16 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -335,11 +335,6 @@ SYSCALL_DEFINE4(sync_file_range, int, fd, loff_t, offset, loff_t, nbytes, goto out_put; mapping = f.file->f_mapping; - if (!mapping) { - ret = -EINVAL; - goto out_put; - } - ret = 0; if (flags & SYNC_FILE_RANGE_WAIT_BEFORE) { ret = filemap_fdatawait_range(mapping, offset, endbyte);