From: Jan Kundrát Date: Thu, 7 Mar 2019 13:16:51 +0000 (+0100) Subject: pinctrl: mcp23s08: Do not complain about unsupported params X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=e0e31695b53b649dc2784c4dd517bcdd09bce189;p=openwrt%2Fstaging%2Fblogic.git pinctrl: mcp23s08: Do not complain about unsupported params It is expected that some of these operations won't work on each and every HW. Previously, even a simple `cat /sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg output. Signed-off-by: Jan Kundrát Cc: Phil Reid Cc: Sebastian Reichel Cc: Linus Walleij Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 5d7a8514def9..fd9d6f026d70 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -266,7 +266,6 @@ static int mcp_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, status = (data & BIT(pin)) ? 1 : 0; break; default: - dev_err(mcp->dev, "Invalid config param %04x\n", param); return -ENOTSUPP; } @@ -293,7 +292,7 @@ static int mcp_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, ret = mcp_set_bit(mcp, MCP_GPPU, pin, arg); break; default: - dev_err(mcp->dev, "Invalid config param %04x\n", param); + dev_dbg(mcp->dev, "Invalid config param %04x\n", param); return -ENOTSUPP; } }