From: Daniel Golle <daniel@makrotopia.org>
Date: Sun, 17 Oct 2021 08:34:55 +0000 (+0100)
Subject: jail: netifd: check target netns fd before using it
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=e1d7cee59b08655c224999b21e9fbf139f5ee54e;p=project%2Fprocd.git

jail: netifd: check target netns fd before using it

Make sure filehandler is non-negative before using it.

Coverity CID: 1492888 Negative returns
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---

diff --git a/jail/netifd.c b/jail/netifd.c
index f6f2df6..0f05ccc 100644
--- a/jail/netifd.c
+++ b/jail/netifd.c
@@ -469,6 +469,10 @@ int jail_network_start(struct ubus_context *new_ctx, char *new_jail_name, pid_t
 	watch_ubus_service();
 
 	netns_fd = ns_open_pid("net", ns_pid);
+	if (netns_fd < 0) {
+		ret = ESRCH;
+		goto errout_inotify;
+	}
 
 	netns_updown(host_ubus_ctx, jail_name, true, netns_fd);