From: Adrian Bunk Date: Thu, 18 Oct 2007 10:52:50 +0000 (+0200) Subject: USB iowarrior.c: fix check-after-use X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=e28c6a77061ab28bd2f0b57e400e3e58cd3474ca;p=openwrt%2Fstaging%2Fblogic.git USB iowarrior.c: fix check-after-use The Coverity checker spotted that we have already oops'ed if "dev" was NULL. Since "dev" being NULL doesn't seem to be possible here this patch removes the NULL check. Signed-off-by: Adrian Bunk Acked-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index d372fbc4effb..c86c132d8aae 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -351,7 +351,7 @@ static ssize_t iowarrior_write(struct file *file, mutex_lock(&dev->mutex); /* verify that the device wasn't unplugged */ - if (dev == NULL || !dev->present) { + if (!dev->present) { retval = -ENODEV; goto exit; }