From: Rasmus Villemoes Date: Wed, 19 Jun 2019 10:02:38 +0000 (+0000) Subject: net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6250_g1_vtu_loadpurge() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=e41d4bc554dedf80590f5fe4a1805bc9383b42e7;p=openwrt%2Fstaging%2Fblogic.git net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6250_g1_vtu_loadpurge() The comment is correct, but the code ends up moving the bits four places too far, into the VTUOp field. Fixes: bec8e5725281 (net: dsa: mv88e6xxx: implement vtu_getnext and vtu_loadpurge for mv88e6250) Signed-off-by: Rasmus Villemoes Signed-off-by: David S. Miller --- diff --git a/drivers/net/dsa/mv88e6xxx/global1_vtu.c b/drivers/net/dsa/mv88e6xxx/global1_vtu.c index 45040f963142..4f7b522e5e59 100644 --- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c +++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c @@ -444,7 +444,7 @@ int mv88e6250_g1_vtu_loadpurge(struct mv88e6xxx_chip *chip, * VTU DBNum[5:4] are located in VTU Operation 9:8 */ op |= entry->fid & 0x000f; - op |= (entry->fid & 0x0030) << 8; + op |= (entry->fid & 0x0030) << 4; } return mv88e6xxx_g1_vtu_op(chip, op);