From: Wei Yongjun Date: Tue, 9 Apr 2013 08:44:29 +0000 (-0300) Subject: [media] rc: nuvoton-cir: fix potential double free in nvt_probe() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=f73e1851c3e196b7089eb5163a7f6bf491d9b46b;p=openwrt%2Fstaging%2Fblogic.git [media] rc: nuvoton-cir: fix potential double free in nvt_probe() Since rc_unregister_device() frees its argument, the subsequently call to rc_free_device() on the same variable will cause a double free bug. Fix by set argument to NULL, thus when fall through to rc_free_device(), nothing will be done there. Signed-off-by: Wei Yongjun Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c index 40125d779049..21ee0dc1b7ec 100644 --- a/drivers/media/rc/nuvoton-cir.c +++ b/drivers/media/rc/nuvoton-cir.c @@ -1107,6 +1107,7 @@ exit_release_cir_addr: release_region(nvt->cir_addr, CIR_IOREG_LENGTH); exit_unregister_device: rc_unregister_device(rdev); + rdev = NULL; exit_free_dev_rdev: rc_free_device(rdev); kfree(nvt);