From: Arnd Bergmann Date: Tue, 24 Jul 2018 09:35:59 +0000 (+0200) Subject: media: platform: cros-ec-cec: Fix dependency on MFD_CROS_EC X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=f863ae594d33e57aa12cdde47e767e6e7942ee51;p=openwrt%2Fstaging%2Fblogic.git media: platform: cros-ec-cec: Fix dependency on MFD_CROS_EC Without the MFD driver, we run into a link error: drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit': cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status' drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr': cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status' drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable': cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status' As we can compile-test all the dependency, the extra '| COMPILE_TEST' is not needed to get the build coverage, and we can simply turn MFD_CROS_EC into a hard dependency to make it build in all configurations. Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver") Signed-off-by: Arnd Bergmann Signed-off-by: Lee Jones --- diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index e4fc59bba1db..60b8c260c9e9 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS config VIDEO_CROS_EC_CEC tristate "ChromeOS EC CEC driver" - depends on MFD_CROS_EC || COMPILE_TEST + depends on MFD_CROS_EC select CEC_CORE select CEC_NOTIFIER ---help---