From: Hans Holmberg Date: Mon, 11 Feb 2019 12:25:02 +0000 (+0100) Subject: lightnvm: pblk: stop taking the free lock in in pblk_lines_free X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=f9324980d7300f961e9895ad94d5ea71c0fe187e;p=openwrt%2Fstaging%2Fblogic.git lightnvm: pblk: stop taking the free lock in in pblk_lines_free pblk_line_meta_free might sleep (it can end up calling vfree, depending on how we allocate lba lists), and this can lead to a BUG() if we wake up on a different cpu and release the lock. As there is no point of grabbing the free lock when pblk has shut down, remove the lock. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling Signed-off-by: Jens Axboe --- diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index f9a3e47b6a93..eb0135c77805 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -584,14 +584,12 @@ static void pblk_lines_free(struct pblk *pblk) struct pblk_line *line; int i; - spin_lock(&l_mg->free_lock); for (i = 0; i < l_mg->nr_lines; i++) { line = &pblk->lines[i]; pblk_line_free(line); pblk_line_meta_free(l_mg, line); } - spin_unlock(&l_mg->free_lock); pblk_line_mg_free(pblk);