From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 22 Sep 2009 00:02:30 +0000 (-0700)
Subject: mm: kmem_cache_create(): make it easier to catch NULL cache names
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=fe1ff49d0d1c30254dbfc84c3786eb538e0cc7d1;p=openwrt%2Fstaging%2Fblogic.git

mm: kmem_cache_create(): make it easier to catch NULL cache names

Right now, if you inadvertently pass NULL to kmem_cache_create() at boot
time, it crashes much later after boot somewhere deep inside sysfs which
makes it very non obvious to figure out what's going on.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/mm/slub.c b/mm/slub.c
index 0a216aae227e..4996fc719552 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3345,6 +3345,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size,
 {
 	struct kmem_cache *s;
 
+	if (WARN_ON(!name))
+		return NULL;
+
 	down_write(&slub_lock);
 	s = find_mergeable(size, align, flags, name, ctor);
 	if (s) {