project/netifd.git
9 years agoFix regression with IPv6 source-dest-routes
Steven Barth [Sat, 21 Mar 2015 18:20:24 +0000 (19:20 +0100)]
Fix regression with IPv6 source-dest-routes

9 years agoadd missing argument for ipv4 routes
Steven Barth [Thu, 19 Mar 2015 17:30:02 +0000 (18:30 +0100)]
add missing argument for ipv4 routes

Signed-off-by: Steven Barth <steven@midlink.org>
9 years agoAdd table argument to shell API for routes
Steven Barth [Thu, 19 Mar 2015 17:28:30 +0000 (18:28 +0100)]
Add table argument to shell API for routes

Signed-off-by: Steven Barth <steven@midlink.org>
9 years agoadd prelocal table to manipulate locally destinated traffic
Steven Barth [Thu, 19 Mar 2015 17:13:33 +0000 (18:13 +0100)]
add prelocal table to manipulate locally destinated traffic

Signed-off-by: Steven Barth <steven@midlink.org>
9 years agonetifd:Make sure interface device config is also cached
Hans Dedecker [Wed, 18 Mar 2015 15:54:48 +0000 (16:54 +0100)]
netifd:Make sure interface device config is also cached

Fixes issue interface device config is not applied in some cases.
As the interface device config was applied but not always cached;
an interface device config diff was not always detected.

Simplify device config setting by exposing as api only device_apply_config

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agonetifd: fixes for json-c 0.12
John Crispin [Thu, 5 Mar 2015 18:44:31 +0000 (19:44 +0100)]
netifd: fixes for json-c 0.12

Signed-off-by: John Crispin <blogic@openwrt.org>
9 years agowireless: fix teardown, always pass the previous config to the teardown handler inste...
Felix Fietkau [Sat, 28 Feb 2015 07:36:08 +0000 (20:36 +1300)]
wireless: fix teardown, always pass the previous config to the teardown handler instead of the new one

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agonetifd: Set interface device config when device has old settings
Hans Dedecker [Thu, 12 Feb 2015 16:41:17 +0000 (17:41 +0100)]
netifd: Set interface device config when device has old settings

If interface device settings are removed in UCI they were not removed in the
device settings; calling device_set_config when device settings are present
solves this.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agonetifd: Keep reference to a config copy in device type specific reload handler as...
Hans Dedecker [Thu, 12 Feb 2015 16:41:16 +0000 (17:41 +0100)]
netifd: Keep reference to a config copy in device type specific reload handler as the original config pointer might go stale

Fixes random observed crashes in blobmsg_parse when device type specific
config data is parsed.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agonetifd: Fix possible hotplug race conditions
Hans Dedecker [Thu, 12 Feb 2015 16:41:15 +0000 (17:41 +0100)]
netifd: Fix possible hotplug race conditions

Don't drop ifup/ifdown events in case an interface event is cached
as it leads to possible race conditions (eg firewall not being
reloaded as ifup is dropped) when multiple interface events are fired
in a short timeframe (eg multiple PPP link flaps).
Always overwrite the cached interface event except for the
interface update event so the hotplug scripts are launched
with the last known status.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agoutils.c: add missing include
Felix Fietkau [Mon, 16 Feb 2015 09:05:01 +0000 (20:05 +1100)]
utils.c: add missing include

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agoRevert "interface: do not set device_config where only the ifname option matches"
Felix Fietkau [Mon, 16 Feb 2015 09:00:58 +0000 (20:00 +1100)]
Revert "interface: do not set device_config where only the ifname option matches"

This reverts commit 8dd2eedafccc9f898d391b93a59efb1412c5b5e9.
This commit was reported to cause a regression with setting MTU on
interfaces.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agonetifd: Add option to configure base_reachable_time_ms for each device
Hans Dedecker [Mon, 2 Feb 2015 15:11:24 +0000 (16:11 +0100)]
netifd: Add option to configure base_reachable_time_ms for each device

The UCI parameter neighreachabletime allows to control the hardware address
to IP mapping lifetime in the neighbour table for both IPv4 and IPv6

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Signed-off-by: Jean-Francois Remy <jeff@melix.org>
9 years agonetifd: Remove unnecessary default_config check in config_parse_interface
Hans Dedecker [Mon, 2 Feb 2015 15:11:23 +0000 (16:11 +0100)]
netifd: Remove unnecessary default_config check in config_parse_interface

No need to check default_config twice as it's already checked in config_parse_interface

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agonetifd: set current_config for simple devices when parsing device config
Hans Dedecker [Mon, 2 Feb 2015 15:11:22 +0000 (16:11 +0100)]
netifd: set current_config for simple devices when parsing device config

If currrent_config is not set when the simple device config is applied the
device will be deleted in device_reset_old

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
9 years agoRevert "vlan: reset device state on init"
Felix Fietkau [Sat, 24 Jan 2015 14:17:02 +0000 (15:17 +0100)]
Revert "vlan: reset device state on init"

This is causing a regression with some VLAN configurations

This reverts commit a4445215e06ee3056427effbef617f4525ee1836.

9 years agodevice: force changes to be applied via state change if necessary
Felix Fietkau [Sat, 24 Jan 2015 00:28:39 +0000 (01:28 +0100)]
device: force changes to be applied via state change if necessary

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agointerface: suppress unnecessary device config overrides
Felix Fietkau [Sat, 24 Jan 2015 00:16:25 +0000 (01:16 +0100)]
interface: suppress unnecessary device config overrides

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agointerface: apply device config passed through interface config
Felix Fietkau [Sat, 24 Jan 2015 00:02:57 +0000 (01:02 +0100)]
interface: apply device config passed through interface config

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agodevice: simplify config blob memory allocation handling
Felix Fietkau [Sat, 24 Jan 2015 00:09:23 +0000 (01:09 +0100)]
device: simplify config blob memory allocation handling

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agointerface: do not set device_config where only the ifname option matches
Felix Fietkau [Fri, 23 Jan 2015 23:53:28 +0000 (00:53 +0100)]
interface: do not set device_config where only the ifname option matches

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agovlan: reset device state on init
Felix Fietkau [Fri, 23 Jan 2015 23:47:13 +0000 (00:47 +0100)]
vlan: reset device state on init

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agodevice: apply config changes from device sections
Felix Fietkau [Fri, 23 Jan 2015 23:42:20 +0000 (00:42 +0100)]
device: apply config changes from device sections

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agodevice: move config apply handling to a helper function
Felix Fietkau [Fri, 23 Jan 2015 23:36:55 +0000 (00:36 +0100)]
device: move config apply handling to a helper function

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agodevice: set dev->default_config to false for devices parsed from config
Felix Fietkau [Fri, 23 Jan 2015 22:54:19 +0000 (23:54 +0100)]
device: set dev->default_config to false for devices parsed from config

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agodevice: add support for specifying a configuration for simple vlan devices
Felix Fietkau [Fri, 23 Jan 2015 22:20:29 +0000 (23:20 +0100)]
device: add support for specifying a configuration for simple vlan devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agobridge: fix retrying member enable when the bridge is otherwise empty
Felix Fietkau [Fri, 23 Jan 2015 11:41:56 +0000 (12:41 +0100)]
bridge: fix retrying member enable when the bridge is otherwise empty

Ensure that the bridge gets created before retrying

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agobridge: mark tested members as present during enable retry
Felix Fietkau [Fri, 23 Jan 2015 11:41:07 +0000 (12:41 +0100)]
bridge: mark tested members as present during enable retry

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agobridge: release failed member devices
Felix Fietkau [Fri, 23 Jan 2015 11:34:12 +0000 (12:34 +0100)]
bridge: release failed member devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
9 years agonetifd: Make interface identifier of delegated IPv6 address configurable
Hans Dedecker [Mon, 12 Jan 2015 19:07:55 +0000 (20:07 +0100)]
netifd: Make interface identifier of delegated IPv6 address configurable

The ip6ifaceid UCI interface parameter makes the interface identifier of the delegated IPv6 address configurable.
The parameter can have the following values:
    eui64 : Interface identifier is generated from the interface's MAC address
    random : Interface identifier is generated randomly
    fixed value : Interface identifier is a fixed value (eg ::1:2)

The latter is the default value with a fixed value of ::1 for backwards compatibility

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Signed-off-by: Joeri Barbarien <joeri.barbarien@gmail.com>
10 years agohandler: replace calls to deprecated json_object_object_get
Steven Barth [Tue, 23 Dec 2014 13:29:47 +0000 (14:29 +0100)]
handler: replace calls to deprecated json_object_object_get

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agonetifd: Add mldversion config support
Steven Barth [Tue, 23 Dec 2014 13:12:32 +0000 (14:12 +0100)]
netifd: Add mldversion config support

Config support to set the MLD host version on device level; possible values are :
    1 : MLDv1
    2 : MLDv2

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Cleaned up and simplified.

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agonetifd: Handle link down event in interface setup state as well
Hans Dedecker [Mon, 22 Dec 2014 14:46:16 +0000 (15:46 +0100)]
netifd: Handle link down event in interface setup state as well

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agoEnable callers to pass the source IP of an IPv4 route when using
Kristian Evensen [Mon, 8 Dec 2014 17:42:21 +0000 (18:42 +0100)]
Enable callers to pass the source IP of an IPv4 route when using
proto_add_ipv4_route(). This is useful with for example DHCP in a multihomed
scenario, as it provides an easy way to match default routes with the correct IP
address. One use case for this are applications that monitor the state of the
WAN port, and the WAN port is assigned multiple addresses.

Signed-off-by: Kristian Evensen <kristian.evensen at gmail.com>
10 years agonetifd: Add igmpversion config support
Hans Dedecker [Thu, 4 Dec 2014 12:07:18 +0000 (12:07 +0000)]
netifd: Add igmpversion config support

Config support to set the IGMP host version on device level; possible values are :
    1 : IGMPv1
    2 : IGMPv2
    3 : IGMPv3

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Cleand up and simplified

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agonetifd: Fix interface auto disable when doing network reload
Hans Dedecker [Thu, 4 Dec 2014 12:07:19 +0000 (12:07 +0000)]
netifd: Fix interface auto disable when doing network reload

Keep interface down when interface auto parameter is set to 0 when doing network reload

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Make possible state transitions more clear when handling teardown event
Hans Dedecker [Thu, 4 Dec 2014 12:07:17 +0000 (12:07 +0000)]
netifd: Make possible state transitions more clear when handling teardown event

Improve code readibility regarding state transitions when handling teardown event

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Fix proto shell setup/teardwon race condition
Hans Dedecker [Thu, 4 Dec 2014 12:07:16 +0000 (12:07 +0000)]
netifd: Fix proto shell setup/teardwon race condition

Fix setup race condition when proto shell is in teardown or setup_abort state when setup cmd is received.
Don't change the proto shell state and launch no setup in these conditions so the proto shell teardown
timeout handler does not kill the wrong processes and proto_shell_task_finish takes action on the correct
teardown state.
Don't launch a new setup action when already in setup state.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Fix restore of original device settings
Hans Dedecker [Thu, 4 Dec 2014 12:07:15 +0000 (12:07 +0000)]
netifd: Fix restore of original device settings

Don't restore original device settings based on the device settings flags in system_if_down
as device flags are already reset when the device config is deleted.
Therefore move the masking of the relevant original device settings to system_if_up.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd v2: Fix source routing for IPv4
Kristian Evensen [Wed, 26 Nov 2014 10:16:05 +0000 (10:16 +0000)]
netifd v2: Fix source routing for IPv4

According to the OpenWRT Network documentation for route, the 'source' option is
"The preferred source address when sending to destinations covered by the
target". However, netifd currently stores this value in RTA_SRC on
NEWROUTE/DELROUTE.

RTA_SRC is not used by kernel when handling NEWROUTE nor DELROUTE for IPv4
routes. When adding a new IPv4 route, the source is stored in RTA_PREFSRC and
the option works as specified in documentation. For IPv6, the address is still
stored in RTA_SRC as to not break source-destination routing for IPv6.

v2: Limit patch to IPv4, to prevent breaking IPv6 configurations (thanks Steven
Barth)

Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
10 years agoFix setting blackhole-routes to kernel
Steven Barth [Tue, 25 Nov 2014 22:56:39 +0000 (23:56 +0100)]
Fix setting blackhole-routes to kernel

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agobridge: retry adding members after config reload / device start
Felix Fietkau [Sun, 23 Nov 2014 16:05:54 +0000 (17:05 +0100)]
bridge: retry adding members after config reload / device start

The kernel will refuse to add a vlan device to a bridge when the base
device of that vlan is already a member. This can happen on config
reload.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agonetifd: Add acceptlocal config support
Hans Dedecker [Thu, 13 Nov 2014 15:57:59 +0000 (15:57 +0000)]
netifd: Add acceptlocal config support

Adds support to accept packets with local source address.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Add rpfilter config support
Hans Dedecker [Thu, 13 Nov 2014 15:57:58 +0000 (15:57 +0000)]
netifd: Add rpfilter config support

Reverse path filtering config support; possible values are:
    0: no source validation
    1|strict: strict mode as packet will be dropped if the
    incoming interface is not the best reverse path
    2|loose: loose mode as packet will be dropped if the
    source address is not reachable via any interface

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Remove superfluous system_if_resolve calls
Hans Dedecker [Thu, 13 Nov 2014 15:57:57 +0000 (15:57 +0000)]
netifd: Remove superfluous system_if_resolve calls

Don't resolve the ifindex of the parent device again
when adding vlandev and macvlan devices as the ifindex
has already been resolved.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Fix device ifindex overwrite when processing netlink event messages
Hans Dedecker [Thu, 13 Nov 2014 15:57:56 +0000 (15:57 +0000)]
netifd: Fix device ifindex overwrite when processing netlink event messages

When a device with the same name is deleted and created again in the kernel
the ifindex changes.
A race condition will occur when netlink event messages linked to the old device
are processed and will thus overwrite the correct ifindex of the new device.
Further make sure a valid ifindex is in place for both external and internal
devices when setting the state to enabled.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd : Apply interface metric on subnet routes when reloading ip
Hans Dedecker [Thu, 23 Oct 2014 09:12:54 +0000 (11:12 +0200)]
netifd : Apply interface metric on subnet routes when reloading ip

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd : Reinsert ip parameters (addresses/routes) based on old interface config...
Hans Dedecker [Thu, 23 Oct 2014 09:12:53 +0000 (11:12 +0200)]
netifd : Reinsert ip parameters (addresses/routes) based on old interface config state

Reinserts the config IP parameters as the config_ip
parameter of the new interface is set to false in
interface_alloc and thus not loading the config ip
options of the old interface

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Read current link state when processing netlink event
Hans Dedecker [Thu, 23 Oct 2014 09:13:44 +0000 (11:13 +0200)]
netifd: Read current link state when processing netlink event

Netifd commit b2dcb02570939d98b92c7c55db1c328693a5d52a introduces
a race condition resulting into infinite toggling interfaces
(eg static interfaces with linksensing enabled, vlan interfaces
with proto none (#18106)) when linksensing is enabled resulting into
a crash.
As netlink event messages will be queued on the netlink event socket
the included lower up interface flag will not always represent the
current link state when netifd processes the netlink messages;
by reading the current link state when a netlink event message is
parsed the correct info is passed to the device layer.
This will avoid continuous interface toggling (down/up) triggered
by link state changes based on outdated netlink interface info.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agowireless: use strdup for vif sections
Felix Fietkau [Fri, 24 Oct 2014 13:00:12 +0000 (15:00 +0200)]
wireless: use strdup for vif sections

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agosystem-linux: fix a glob related memleak
Felix Fietkau [Fri, 24 Oct 2014 12:44:34 +0000 (14:44 +0200)]
system-linux: fix a glob related memleak

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoconfig: use sprintf instead of asprintf
Felix Fietkau [Fri, 24 Oct 2014 11:35:30 +0000 (13:35 +0200)]
config: use sprintf instead of asprintf

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agodevice: make link status detection optional for vlan devices
Felix Fietkau [Mon, 20 Oct 2014 20:07:18 +0000 (22:07 +0200)]
device: make link status detection optional for vlan devices

Fixes a race condition that triggers endless link loss / detect calls
when VLAN devices are created.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: fix for not handling switch from DHCP to static race
Michel Stam [Thu, 2 Oct 2014 11:39:16 +0000 (11:39 +0000)]
proto-shell: fix for not handling switch from DHCP to static race

When a shell script call is finished, proto_shell_task_finish( ) is
called to monitor processes, and determine the next interface state.

When the interface is brought up after a reconfiguration from dhcp
to static, it will first try to (erroneously?) reconfigure the
interface for DHCP. Upon doing this, it realises the mistake and
kills off the script by setting the state to S_SETUP_ABORT. This is
done by the proto_shell_handler. When this happens. the scripts
have 1 second to finish.
When this happens, S_SETUP_ABORT in proto_shell_task_finish( )
should issue a 'teardown' event to the shell script to deconfigure
the interface. It is here that things go wrong.

Shell scripts do not execute commands themselves, they should
finish as quick as possible. This is very race condition sensitive,
though; Instead of executing commands, they post messages to
execute commands. It is therefore possible that when the script
finishes, there's still commands to execute.

The dhcp protocol handler script, one of the scripts involved,
notifies netifd of changes by (indirectly) calling
proto_shell_update_link( ).

Once every so often, the dhcp script will not be finished in time,
and proto_shell_task_finish( ) cannot immediately continue,
because (in this case) the proto_task is still pending.

If this happens, the proto_shell_task_finish( ) will wait, but if
the proto_shell_update_link( ) notification is then received, it
will set the statemachine to idle, thus breaking the
S_SETUP_ABORT. Furthermore, an event is generated to indicate that
the network interface should be set to UP, rather than DOWN.

This confuses netifd, and the result is a stuck process that does
not respond to UCI calls anymore.

Note that a similar situation happens in the S_TEARDOWN state in
proto_shell_task_finish( ).

The fix, although a bit ugly, is to prevent the UP event from
being sent, and not to reset the state machine to idle in
proto_shell_update_link( ).

Signed-off-by: Michel Stam <m.stam@fugro.nl>
10 years agonetifd: Fix lost interface device config for devices having default config
Hans Dedecker [Fri, 10 Oct 2014 13:35:08 +0000 (13:35 +0000)]
netifd: Fix lost interface device config for devices having default config

As the PPP main device (either a simple or old style vlan device) is freed when PPP interfaces are reloaded; interface device specific config (eg mtu/macaddr/...) is lost as the interface config is not re-applied on the newly created device.
Patch fixes the issue by re-applying the interface device config after the main device is claimed and is having default config.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd : Line up device.h include guard
Hans Dedecker [Fri, 10 Oct 2014 13:35:07 +0000 (13:35 +0000)]
netifd : Line up device.h include guard

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agoconfig: define _GNU_SOURCE for asprintf
Felix Fietkau [Tue, 7 Oct 2014 12:10:06 +0000 (14:10 +0200)]
config: define _GNU_SOURCE for asprintf

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agowireless: print the active configuration in status info
Felix Fietkau [Sat, 4 Oct 2014 18:30:58 +0000 (20:30 +0200)]
wireless: print the active configuration in status info

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agowireless: fix blob buf in put_container()
Felix Fietkau [Sat, 4 Oct 2014 18:30:24 +0000 (20:30 +0200)]
wireless: fix blob buf in put_container()

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agowireless: display anonymous interface section names using index based extended syntax
Felix Fietkau [Wed, 1 Oct 2014 13:05:00 +0000 (15:05 +0200)]
wireless: display anonymous interface section names using index based extended syntax

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agowireless: copy the vif section name instead of keeping a reference that might go...
Felix Fietkau [Wed, 1 Oct 2014 13:03:30 +0000 (15:03 +0200)]
wireless: copy the vif section name instead of keeping a reference that might go stale

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agonetifd: IPIP tunnel support
Hans Dedecker [Thu, 2 Oct 2014 13:37:20 +0000 (13:37 +0000)]
netifd: IPIP tunnel support

Adds IPIP tunnel support to netifd.
Following IPIP tunnel parameters can be configured :
   -peeraddr (IPv4 remote address)
   -ipaddr (IPv4 local address)
   -mtu (IPIP tunnel mtu)
   -ttl (time to live of encapsulting packets)
   -tos (type of service either inherit (outer header inherits the value of the inner header) or hex value)
   -df (don't fragment flag of encapsulating packets)
   -tunlink (bind tunnel to this interface)

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: GRE Tos support
Hans Dedecker [Mon, 29 Sep 2014 15:36:04 +0000 (15:36 +0000)]
netifd: GRE Tos support

Tos support is added as a generic gre parameter which can have the following values :
     -inherit (outer header inherits the tos value of the inner header)
     -hex value

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd-device: add support for promisc setting
Martin Hundebøll [Mon, 15 Sep 2014 09:57:50 +0000 (11:57 +0200)]
netifd-device: add support for promisc setting

Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
10 years agoipv6: work around kernel on-link handling issue
Steven Barth [Mon, 8 Sep 2014 14:40:50 +0000 (16:40 +0200)]
ipv6: work around kernel on-link handling issue

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agointerface: call proto teardown before marking the interface as down
Felix Fietkau [Sun, 31 Aug 2014 13:06:42 +0000 (15:06 +0200)]
interface: call proto teardown before marking the interface as down

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agointerface: do not try to bring up an unavailable interface
Felix Fietkau [Sun, 31 Aug 2014 13:03:20 +0000 (15:03 +0200)]
interface: do not try to bring up an unavailable interface

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agointerface: cancel the remove timer on cleanup
Felix Fietkau [Sun, 31 Aug 2014 12:57:34 +0000 (14:57 +0200)]
interface: cancel the remove timer on cleanup

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: also set proto_task_killed for SIGKILL
Felix Fietkau [Sun, 31 Aug 2014 12:22:52 +0000 (14:22 +0200)]
proto-shell: also set proto_task_killed for SIGKILL

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: set proto_task_killed for SIGTERM only
Ulrich Weber [Tue, 10 Jun 2014 10:51:06 +0000 (10:51 +0000)]
proto-shell: set proto_task_killed for SIGTERM only

otherwise teardown will not kill the process
if the interface was renewed before, which
set proto_task_killed

Signed-off-by: Ulrich Weber <uw@ocedo.com>
10 years agohandler: explicitly include json.h
Felix Fietkau [Wed, 13 Aug 2014 21:07:24 +0000 (23:07 +0200)]
handler: explicitly include json.h

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoipv6: assign prefixes with length <64 with /64 on-link routes
Steven Barth [Wed, 13 Aug 2014 14:35:28 +0000 (16:35 +0200)]
ipv6: assign prefixes with length <64 with /64 on-link routes

on-link routes for prefixes bigger than /64 make no sense and
might confuse some users

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agonetifd: More fine grained handling of unwanted proto shell actions
Hans Dedecker [Thu, 7 Aug 2014 08:44:31 +0000 (08:44 +0000)]
netifd: More fine grained handling of unwanted proto shell actions

In commit e1ec2d2b9e7f7692a4ff88a0361bbcdbe34f0d99 (proto-shell: extend race condition avoidance), changes were made to prevent notifications from the proto handler during the proto shell states teardown and abort.
These changes unfortunately also prevent netifd from being notified of a number of proto handler events like notify_error, blok_restart and kill during the teardown state.
This introduces issues when the protocol is ppp, the authfail UCI parameter is set and authentication fails; the interface autostart parameter cannot be set to disabled while the ppp daemon keeps running as these proto handler notifications are dropped in the teardown state.
The attached patch blocks the notifications in the individual notification handlers which should not get notifications during teardown/abort state and allows notify_error/blok_restart/kill notifications during these states.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agoDisable new-style tunnel creation for older kernels
Steven Barth [Wed, 6 Aug 2014 11:23:12 +0000 (13:23 +0200)]
Disable new-style tunnel creation for older kernels

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agonetifd: Accept notify errors in proto_shell teardown or abort state
Hans Dedecker [Tue, 5 Aug 2014 08:22:27 +0000 (08:22 +0000)]
netifd: Accept notify errors in proto_shell teardown or abort state

In commit e1ec2d2b9e7f7692a4ff88a0361bbcdbe34f0d99 (proto-shell: extend race condition avoidance), changes were made to prevent notifications from the proto handler during teardown.
According to the comments, this was done to avoid the shell proto state being reset to S_IDLE and the interface hanging in IFS_TEARDOWN state.
These changes unfortunately also prevent netifd from being notified of the errors (proto_shell_notify_error) that actually caused the teardown.
This is for instance an issue when the protocol is ppp and e.g.  PAP/CHAP authentication fails.
Since proto_shell_notify_error does not touch the proto state, it seems like a good idea to at least allow these notifications in teardown state.
The attached patch accomplishes this.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Signed-off-by: Joeri Barbarien <joeri.barbarien@gmail.com>
10 years agonetifd: fix incorrect number of bytes memset in clear_if_addr
Hans Dedecker [Tue, 5 Aug 2014 08:22:26 +0000 (08:22 +0000)]
netifd: fix incorrect number of bytes memset in clear_if_addr

Fix clear_if_addr for IPv6 addresses as an incorrect number of bytes were memset due to wrong sizeof argument

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: GRE tunnel support
Hans Dedecker [Wed, 30 Jul 2014 10:56:31 +0000 (10:56 +0000)]
netifd: GRE tunnel support

Adds support for gre, gretap, grev6 and grev6tap tunnels

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Allow to add link devices which can be marked as non external
Hans Dedecker [Wed, 30 Jul 2014 10:56:30 +0000 (10:56 +0000)]
netifd: Allow to add link devices which can be marked as non external

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agonetifd: Set device down based on being a non external device in device_release
Hans Dedecker [Wed, 30 Jul 2014 10:56:29 +0000 (10:56 +0000)]
netifd: Set device down based on being a non external device in device_release

Line up the device state manipulation by checking the external device parameter consistent and not the hotplug device parameter

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
10 years agoadd_dynamic: remove redundant code
Steven Barth [Tue, 29 Jul 2014 16:43:45 +0000 (18:43 +0200)]
add_dynamic: remove redundant code

device_config is unneeded since add_dynamic is used to create aliases
checking of setup state is unneeded because of race condition fixes

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agoproto-shell: extend race condition avoidance
Steven Barth [Tue, 29 Jul 2014 16:41:51 +0000 (18:41 +0200)]
proto-shell: extend race condition avoidance

Disallow all notifications from the proto handler during teardown to
avoid the shell proto state being reset to S_IDLE and the interface
hanging in IFS_TEARDOWN state.

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agoubus: add del_dynamic as complement to add_dynamic
Steven Barth [Mon, 28 Jul 2014 19:48:26 +0000 (21:48 +0200)]
ubus: add del_dynamic as complement to add_dynamic

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agointerface: enable force_link by default for proto=static
Felix Fietkau [Sun, 27 Jul 2014 11:21:22 +0000 (13:21 +0200)]
interface: enable force_link by default for proto=static

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: fix renew_pending handling
Felix Fietkau [Sat, 26 Jul 2014 14:35:49 +0000 (16:35 +0200)]
proto-shell: fix renew_pending handling

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: fix setup/renew race condition
Felix Fietkau [Sat, 26 Jul 2014 01:46:39 +0000 (03:46 +0200)]
proto-shell: fix setup/renew race condition

If a renew event arrives before the setup event has been processed, the
renew event needs to be deferred, otherwise interfaces can get stuck

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoOnly add dynamic interfaces if the underlying interface is ready
Steven Barth [Thu, 24 Jul 2014 22:01:50 +0000 (00:01 +0200)]
Only add dynamic interfaces if the underlying interface is ready

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agoproto-shell: don't accept up-notifications in teardown state
Steven Barth [Thu, 24 Jul 2014 19:18:00 +0000 (21:18 +0200)]
proto-shell: don't accept up-notifications in teardown state

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agointerface: fix restart after reload with external devices
Felix Fietkau [Thu, 24 Jul 2014 09:12:48 +0000 (11:12 +0200)]
interface: fix restart after reload with external devices

When an interface goes down, the main_dev is reset to NULL.
Track an externally added device separately to be able to bring it back
up.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agobridge: enable multicast querier functionality by default
Felix Fietkau [Thu, 24 Jul 2014 08:54:14 +0000 (10:54 +0200)]
bridge: enable multicast querier functionality by default

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoSet DEVICE for legacy ifupdate event as well
Steven Barth [Wed, 23 Jul 2014 16:06:47 +0000 (18:06 +0200)]
Set DEVICE for legacy ifupdate event as well

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agoMake dynamic interfaces always autostart
Steven Barth [Wed, 23 Jul 2014 16:04:47 +0000 (18:04 +0200)]
Make dynamic interfaces always autostart

Signed-off-by: Steven Barth <steven@midlink.org>
10 years agoscripts: set type for the "key" attribute
Felix Fietkau [Fri, 18 Jul 2014 11:37:08 +0000 (13:37 +0200)]
scripts: set type for the "key" attribute

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agobridge: enable IGMP snooping by default
Felix Fietkau [Thu, 17 Jul 2014 14:56:14 +0000 (16:56 +0200)]
bridge: enable IGMP snooping by default

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agointerface: clean up l3 device reference on remove/reload
Felix Fietkau [Sun, 29 Jun 2014 21:27:29 +0000 (23:27 +0200)]
interface: clean up l3 device reference on remove/reload

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agobridge: enable multicast_to_unicast on all wireless bridge ports
Felix Fietkau [Sun, 29 Jun 2014 18:31:26 +0000 (20:31 +0200)]
bridge: enable multicast_to_unicast on all wireless bridge ports

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agodevice: fall back to simple interface status check if not provided by the device...
Felix Fietkau [Thu, 26 Jun 2014 10:17:46 +0000 (12:17 +0200)]
device: fall back to simple interface status check if not provided by the device type

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agointerface: fix indentation
Felix Fietkau [Thu, 26 Jun 2014 10:09:21 +0000 (12:09 +0200)]
interface: fix indentation

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agoproto-shell: add debug msg for calling handlers
Felix Fietkau [Thu, 26 Jun 2014 10:07:24 +0000 (12:07 +0200)]
proto-shell: add debug msg for calling handlers

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agosystem-dummy: set present flags on all devices
Felix Fietkau [Thu, 26 Jun 2014 10:04:15 +0000 (12:04 +0200)]
system-dummy: set present flags on all devices

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
10 years agointerface: don't store table id in route if the default table is used
Steven Barth [Fri, 20 Jun 2014 17:50:13 +0000 (19:50 +0200)]
interface: don't store table id in route if the default table is used

Use system_is_default_rt_table() to test whether the resolved routing table
is the default one, in this case do not apply the table attribute to the
route object.

This is needed for backwards compatibility - only routes using a non-default
table shall report it in the ifstatus output.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>