openwrt/staging/blogic.git
9 years agostaging: fsl-mc: Changed dev_info() calls to dev_dbg()
J. German Rivera [Sat, 17 Oct 2015 16:18:16 +0000 (11:18 -0500)]
staging: fsl-mc: Changed dev_info() calls to dev_dbg()

Changed dev_info() calls to dev_dbg() in
fsl_mc_allocator_probe/fsl_mc_allocator_remove, as they
are useful only for debugging.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: dpmcp opening/closing refactoring
J. German Rivera [Sat, 17 Oct 2015 16:18:15 +0000 (11:18 -0500)]
staging: fsl-mc: dpmcp opening/closing refactoring

Before, we were opening and closing a mc_io's dpmcp object
in fsl_mc_portal_reset(), since that was the only function that was
calling dpmcp MC operations. However, it is better for maintainability
to open the dpmcp object when it gets associated with an mc_io object,
and close it when this association is terminated. This way, we are free
to call dpmcp operations on a mc_io's dpmcp object at any time, without
having to check if the dpmcp object is opened or not.

Consequently, the creation/teardown of the association between
an mc_io object and a dpmcp is now encapsulated in two functions:
fsl_mc_io_set_dpmcp()/fsl_mc_io_unset_dpmcp(). Besides, setting
the corresponding pointers for the association, these functions
open and close the dpmcp object respectively.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: fsl_mc_io object refactoring
J. German Rivera [Sat, 17 Oct 2015 16:18:14 +0000 (11:18 -0500)]
staging: fsl-mc: fsl_mc_io object refactoring

Each fsl_mc_io object is associated with an fsl_mc_device object
of type "dpmcp" representing the MC portal associated with the
fsl_mc_io object. Before, we were representing this association with
an fsl_mc_resource pointer. To enhance code clarity, it is more
straight forward to use an fsl_mc_device pointer instead.
So, this change replaces the 'resource' field in the fsl_mc_io
object with 'dpmcp_dev'. Also, it changes parameter 'resource' of
fsl_create_mc_io() to be an fsl_mc_device pointer instead.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: Naming cleanup in fsl_mc-portal_allocate
J. German Rivera [Sat, 17 Oct 2015 16:18:13 +0000 (11:18 -0500)]
staging: fsl-mc: Naming cleanup in fsl_mc-portal_allocate

mc_adev is a local variable for the allocated dpmcp object.
Renamed mc_adev as dpmcp_dev for clarity.

Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: r8723au: move * to be adjacent to pointer name
Alison Schofield [Sat, 17 Oct 2015 16:19:46 +0000 (18:19 +0200)]
staging: r8723au: move * to be adjacent to pointer name

Move * in pointer types to be adjacent to pointer names per Linux
coding style.

Addresses checkpatch.pl: ERROR: "foo*    bar" should be "foo *bar"

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: include : Remove unused macros
Ksenija Stanojevic [Sat, 17 Oct 2015 16:19:46 +0000 (18:19 +0200)]
Staging: lustre: include : Remove unused macros

These macro are not used anymore, therefore remove them.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: include: Convert macro class_export_lock_put into static inline...
Ksenija Stanojevic [Sat, 17 Oct 2015 16:19:46 +0000 (18:19 +0200)]
Staging: lustre: include: Convert macro class_export_lock_put into static inline function

Static inline functions are preferred over macros. This change is safe
because the types of arguments at all the call sites are same.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: include: Convert macro class_export_lock_get into static inline...
Ksenija Stanojevic [Sat, 17 Oct 2015 16:18:34 +0000 (18:18 +0200)]
Staging: lustre: include: Convert macro class_export_lock_get into static inline function

Static inline functions are preferred over macros. This change is safe
because the types of arguments at all the call sites are same.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: include: Move function prototypes
Ksenija Stanojevic [Sat, 17 Oct 2015 16:17:05 +0000 (18:17 +0200)]
Staging: lustre: include: Move function prototypes

Functions:
struct obd_export *class_export_get(struct obd_export *exp);
void class_export_put(struct obd_export *exp)
are being used in macros that are converted into static inline
functions, therefore move function prototypes to avoid build
error in later patches.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: card.c rename pDevice with priv
Malcolm Priestley [Sat, 17 Oct 2015 10:33:02 +0000 (11:33 +0100)]
staging: vt6655: card.c rename pDevice with priv

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: rename pOpts and sOpts to opts.
Malcolm Priestley [Sat, 17 Oct 2015 10:33:01 +0000 (11:33 +0100)]
staging: vt6655: rename pOpts and sOpts to opts.

bring pointers and members into line.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: remove static inline alloc_td_info.
Malcolm Priestley [Sat, 17 Oct 2015 10:33:00 +0000 (11:33 +0100)]
staging: vt6655: remove static inline alloc_td_info.

Since this only contains one function and used only twice remove
inline altogether.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: remove static inline alloc_rd_info.
Malcolm Priestley [Sat, 17 Oct 2015 10:32:59 +0000 (11:32 +0100)]
staging: vt6655: remove static inline alloc_rd_info.

Since this only contains one function and only used twice
remove inline altogether.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: replace typedef struct __device_opt
Malcolm Priestley [Sat, 17 Oct 2015 10:32:58 +0000 (11:32 +0100)]
staging: vt6655: replace typedef struct __device_opt

with struct vnt_options and members
rx_descs0 for nRxDescs0
rx_descs1 for nRxDescs1
tx_descs for nTxDescs
int_works
short_retry
long_retry
bbp_type
flags

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device.h remove typedef enum
Malcolm Priestley [Sat, 17 Oct 2015 10:32:57 +0000 (11:32 +0100)]
staging: vt6655: device.h remove typedef enum

Covert values to macros.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device.h remove unsed headers.
Malcolm Priestley [Sat, 17 Oct 2015 10:32:56 +0000 (11:32 +0100)]
staging: vt6655: device.h remove unsed headers.

Most of these headers rate to old api that are no longer used
in driver.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device.h remove unused macros.
Malcolm Priestley [Sat, 17 Oct 2015 10:32:55 +0000 (11:32 +0100)]
staging: vt6655: device.h remove unused macros.

None of these are used in driver anymore.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_main Replace uIdx with idx.
Malcolm Priestley [Sat, 17 Oct 2015 10:32:54 +0000 (11:32 +0100)]
staging: vt6655: device_main Replace uIdx with idx.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: sm750fb: Prefer using BIT Macro
Amitoj Kaur Chawla [Sat, 17 Oct 2015 15:50:00 +0000 (21:20 +0530)]
staging: sm750fb: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro
Problem found using checkpatch.pl
WARNING: 'Prefer using the BIT macro'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: mt29f_spinand: Remove space after a cast
Eva Rachel Retuya [Sat, 17 Oct 2015 15:52:26 +0000 (23:52 +0800)]
Staging: mt29f_spinand: Remove space after a cast

Modify retval to reflect removal of space during cast operation.
Checkpatch found this issue.

CHECK: No space is necessary after a cast

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: wilc1000: Remove unnecessary parentheses
Aybuke Ozdemir [Sat, 17 Oct 2015 12:25:35 +0000 (15:25 +0300)]
Staging: wilc1000: Remove unnecessary parentheses

Problem found using checkpatch.pl:
CHECK: Unnecessary parentheses around pstrNetworkInfo->u8SsidLen

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: wilc1000: Remove unnecessary else after return
Aybuke Ozdemir [Sat, 17 Oct 2015 12:25:34 +0000 (15:25 +0300)]
Staging: wilc1000: Remove unnecessary else after return

Problem found using checkpatch.pl:
WARNING: else is not generally useful after a break or return

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: wilc1000: Remove multiple blank lines
Aybuke Ozdemir [Sat, 17 Oct 2015 12:25:33 +0000 (15:25 +0300)]
Staging: wilc1000: Remove multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: remove unneeded variable
Greg Kroah-Hartman [Sat, 17 Oct 2015 15:55:15 +0000 (08:55 -0700)]
Staging: lustre: remove unneeded variable

ldlm_lock_enqueue() always returns ELDLM_OK, no matter what happens, so
removed the unneeded variable that this value was being stored in and
just return the value itself.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
9 years agostaging: comedi: cb_pcidas: rename handle_ao_interrupt()
H Hartley Sweeten [Wed, 14 Oct 2015 00:48:02 +0000 (17:48 -0700)]
staging: comedi: cb_pcidas: rename handle_ao_interrupt()

Rename this function so it has namespace associated with the
driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up analog input subdevice init
H Hartley Sweeten [Wed, 14 Oct 2015 00:48:01 +0000 (17:48 -0700)]
staging: comedi: cb_pcidas: tidy up analog input subdevice init

For aesthetics, add some whitespace to the subdevice initialization
and rename the subdevice functions to follow the normal form in
comedi drivers.

Async command support uses interrupts. For clarity, make sure the
driver has an IRQ before initializing command support.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up analog output subdevice init
H Hartley Sweeten [Wed, 14 Oct 2015 00:48:00 +0000 (17:48 -0700)]
staging: comedi: cb_pcidas: tidy up analog output subdevice init

For aesthetics, add some whitespace to the subdevice initialization
and rename the (*insn_write) functions to follow the normal form
in comedi drivers.

It's not possible to actually read the analog outpus. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.

Async command support uses interrupts. For clarity, make sure the
driver has an IRQ before initializing command support.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: rename private data 's5933_intcsr_bits'
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:59 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: rename private data 's5933_intcsr_bits'

For aesthetics, rename this member of the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: rename private data 's5933_config'
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:58 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: rename private data 's5933_config'

For aesthetics, rename this member of the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: fix cb_pcidas_eeprom_insn_read()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:57 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: fix cb_pcidas_eeprom_insn_read()

The comedi core expects (*insn_read) operations to return insn->n
data values. Refactor this function to work like the core expects.

For aesthetics, nvram_read() and use the comedi_timeout() helper
to handle the busy wait for the eeprom to be "ready".

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up memory subdevice init
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:56 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up memory subdevice init

For aesthetics, add some whitespace to the initialization of this
subdevice.

Rename the (*insn_read) function so it has namespace associated with
the driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up 8800 caldac calibration subdevice
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:55 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up 8800 caldac calibration subdevice

For aesthetics, add some whitespace to the subdevice init.

It's not possible to actually read from the caldac. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up dac08_write()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:54 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up dac08_write()

Rename this function so it has namespace associated with the driver.
Also rename the 'value' parameter to avoid having to split the line
to keep it under 80 chars.

Remove the unnecessary masking on the 'value'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up dac08 calibration subdevice
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:53 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up dac08 calibration subdevice

For aesthetics, add some whitespace to the subdevice init.

It's not possible to actually read from the dac08. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: refactor 'trimpot' boardinfo
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:52 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: refactor 'trimpot' boardinfo

Only the pci-das1602/16 boards have an AD8402 trimpot. The rest of
the boards supported by this driver have an AD7376 trimpot.

Replace the 'enum trimpot_module' in the boardinfo with a bit-field
flag 'has_ad8402' to save a bit of space.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up cb_pcidas_trimpot_write()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:51 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up cb_pcidas_trimpot_write()

All the boards supported by this driver have an AD7376 or AD8402
trimpot. Replace the switch () with and if () and remove the
unreachable dev_err() noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: absorb caldac/trimpot write functions
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:50 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: absorb caldac/trimpot write functions

These functions are all just wrappers for cb_pcidas_calib_write().
Remove them and absorb the code into the callers.

Remove the unnecessary masking of the 'chan'. It will always be in
range due to the subdevice initialization.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: refactor write_calibration_bitstream()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:49 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: refactor write_calibration_bitstream()

Refactor this function to handle the common code used to select the
calibration device (trimpot or caldac) and latch the data after
sending the bitstream.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up caldac_8800_write()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:48 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up caldac_8800_write()

Rename this function so it has namespace associated with the driver.

For aesthetics, remove the 'static const' local variables. They don't
add any significant value.

Remove the 'bitstream' local variable. Change the type of the 'value'
param to match the callers type and write_calibration_bitstream()'s
type.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up trimpot_8402_write()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:47 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up trimpot_8402_write()

Rename this function so it has namespace associated with the driver.
Change the return type to void, it always returns '0' and the return
value is never checked.

For aesthetics, remove the 'static const' local variables. They don't
add any significant value.

Remove the 'bitstream' local variable. The 'value' passed to this
function will always be in the correct range due to s->maxdata so
the masking is not necessary. Change the type of the 'value' param
to match the callers type and write_calibration_bitstream()'s type.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up trimpot_7376_write()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:46 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up trimpot_7376_write()

Rename this function so it has namespace associated with the driver.
Change the return type to void, it always returns '0' and the return
value is never checked.

For aesthetics, remove the 'static const' local variables. They don't
add any significant value.

Remove the 'bitstream' local variable. The 'value' passed to this
function will always be in the correct range due to s->maxdata so
the masking is not necessary. Change the type of the 'value' param
to match the callers type and write_calibration_bitstream()'s type.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up calibration trimpot subdevice
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:45 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up calibration trimpot subdevice

For aesthetics, add some whitespace to the subdevice init.

It's not possible to actually read from the trimpot. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.

Move the comment about the channels from trimpot_8402_write() to
the subdevice init and fix the checkpatch.pl issue about:

WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: use preferred kernel types
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:44 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: use preferred kernel types

As suggested by checkpatch.pl:

CHECK: Prefer kernel type 'u8' over 'uint8_t'

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up DAC control/status register
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:43 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up DAC control/status register

Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.

For aesthetics, rename the associated member of the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up calibration register
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:42 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up calibration register

Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up trigger control/status register
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:41 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up trigger control/status register

Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up ADC mux/control register
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:40 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up ADC mux/control register

Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up interrupt/ADC FIFO register
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:39 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up interrupt/ADC FIFO register

Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.

For aesthetics, rename the associated member of the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: convert inline DAC bit helpers to macros
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:38 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: convert inline DAC bit helpers to macros

For aesthetics, convert the inline functions that return the bits
used to set the DAC range and enable bits to macros.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up PCI BAR2 register defines
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:37 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up PCI BAR2 register defines

Rename the defines for the PCI BAR2 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up PCI BAR3 register defines
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:36 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up PCI BAR3 register defines

Rename the defines for the PCI BAR3 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: use comedi_range_is_unipolar()
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:35 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: use comedi_range_is_unipolar()

Instead of relying on the IS_UNIPOLAR mask value, use the comedi
helper function to check if the range is unipolar.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up PCI BAR4 register defines
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:34 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up PCI BAR4 register defines

Convert the inline function DAC_DATA_REG() into a simple macro.

Rename the defines for the PCI BAR4 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: rename private data 'ao_registers'
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:33 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: rename private data 'ao_registers'

This member of the private data holds the PCI BAR4 resource starting
address. For aesthetics, rename this member to 'pcibar4'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: rename private data 'adc_fifo'
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:32 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: rename private data 'adc_fifo'

This member of the private data holds the PCI BAR2 resource starting
address. For aesthetics, rename this member to 'pcibar2'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: rename private data 'control_status'
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:31 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: rename private data 'control_status'

This member of the private data holds the PCI BAR1 resource starting
address. For aesthetics, rename this member to 'pcibar1'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: refactor 'ranges' boardinfo
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:30 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: refactor 'ranges' boardinfo

All the boards, except the 'pci-das1001', use the normal analog input
range table 'cb_pcidas_ranges'. Convert the 'ranges' boardinfo into
a bit-field flag 'use_alt_range' to save a bit of space.

For aesthetics, reword the comments in the boardinfo for the bit-field
members so they align.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: all boards have 16 analog input channels
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:29 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: all boards have 16 analog input channels

All the boards supported by this driver have 16 analog input channels.
Remove this unnecessary information from the boardinfo.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: refactor analog output boardinfo
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:28 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: refactor analog output boardinfo

Only some of the boards supported by this driver have analog outputs
but they always have 2 channels. Refactor the 'ao_nchan' member of
the boardinfo into a bit-field flag 'has_ao' to save a bit of space.
Also, convert the 'has_ao_fifo' member into a bit-field flag.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: refactor 'ai_bits' boardinfo
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:27 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: refactor 'ai_bits' boardinfo

The boards supported by this driver either have 16-bit or 12-bit
analog input/output resolution. For aesthetics, replace the 'ai_bits'
member of the boardinfo with a bit-field flag 'is_16bit'. Also,
change the types of the other bit-field flags to unsigned int.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: remove NUM_CHANNELS_* defines
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:26 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: remove NUM_CHANNELS_* defines

These defines don't add any additional clarity to the driver. Just
remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: comedi: cb_pcidas: tidy up multi-line comments
H Hartley Sweeten [Wed, 14 Oct 2015 00:47:25 +0000 (17:47 -0700)]
staging: comedi: cb_pcidas: tidy up multi-line comments

Reformat the multi-line comments in the kernel CodingStyle.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: netlogic: xlr_net.h: fixed coding style warnings
Sakshi Bansal [Thu, 15 Oct 2015 14:35:03 +0000 (20:05 +0530)]
staging: netlogic: xlr_net.h: fixed coding style warnings

Fixed block comments usage of * on subsequent lines

Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rts5208: use dmam_alloc_coherent
Ronit Halder [Fri, 16 Oct 2015 08:50:20 +0000 (14:20 +0530)]
Staging: rts5208: use dmam_alloc_coherent

This patch replaces dma_alloc_coherent with the corresponding
managed interface.

Signed-off-by: Ronit Halder <ronit.crj@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: fix line-over-80-characters violations
Christian Gromm [Thu, 15 Oct 2015 11:29:00 +0000 (13:29 +0200)]
staging: most: fix line-over-80-characters violations

This patch prevents code from crossing the 80 character margin.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: change parameter description
Christian Gromm [Thu, 15 Oct 2015 11:28:59 +0000 (13:28 +0200)]
staging: most: change parameter description

This patch changes the description of a function parameter for a better
understanding.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: replace memcpy by ether_addr_copy
Christian Gromm [Thu, 15 Oct 2015 11:28:58 +0000 (13:28 +0200)]
staging: most: replace memcpy by ether_addr_copy

This patch replaces memcpy() by the preferred function ether_addr_copy().

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: fix misplaced constants in comparisons
Christian Gromm [Thu, 15 Oct 2015 11:28:57 +0000 (13:28 +0200)]
staging: most: fix misplaced constants in comparisons

This patch removes and fixes constants being misplaced in comparisons.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: make hdm-usb follow the coding style
Christian Gromm [Thu, 15 Oct 2015 11:28:56 +0000 (13:28 +0200)]
staging: most: make hdm-usb follow the coding style

This patch fixes a couple of issues of the hdm-usb module found by
checkpatch.pl.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: fix checkpatch issues of hdm i2c
Christian Gromm [Thu, 15 Oct 2015 11:28:55 +0000 (13:28 +0200)]
staging: most: fix checkpatch issues of hdm i2c

This patch fixes the issues of HDM module i2c found by checkpatch.pl

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: remove constants from comparisons
Christian Gromm [Thu, 15 Oct 2015 11:28:54 +0000 (13:28 +0200)]
staging: most: remove constants from comparisons

This patch removes constants from comparisons and fixes checkpatch warnings
about constants being put in the wrong place inside a comparison.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: most: correct coding style breaches
Christian Gromm [Thu, 15 Oct 2015 11:28:51 +0000 (13:28 +0200)]
staging: most: correct coding style breaches

This patch fixes line-over-80-characters violation and removes the
splitting of quoted strings.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: most: cdev: Remove useless check
Shivani Bhardwaj [Thu, 15 Oct 2015 10:42:01 +0000 (16:12 +0530)]
Staging: most: cdev: Remove useless check

The variable mbo is already NULL tested so, check on it should be
removed.
Semantic patch used:

@@ expression E;
statement S; @@
if(E==NULL) {... return ...;}
- if(E)
  S

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: most: fix style issue in aim-cdev/cdev.c
Gavin Thomas Claugus [Tue, 13 Oct 2015 21:44:40 +0000 (17:44 -0400)]
Staging: most: fix style issue in aim-cdev/cdev.c

Fix 80+ character line in cdev.c to stop checkpatch from whining.

Signed-off-by: Gavin Thomas Claugus <gclaugus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: olpc_dcon: Remove NULL comparison
Aybuke Ozdemir [Fri, 16 Oct 2015 18:51:45 +0000 (21:51 +0300)]
Staging: olpc_dcon: Remove NULL comparison

Problem found using checkpatch.pl
CHECK: Comparison to NULL could be written "(!)dcon_device"

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: olpc_dcon: Use preferred kernel type
Aybuke Ozdemir [Fri, 16 Oct 2015 18:51:44 +0000 (21:51 +0300)]
Staging: olpc_dcon: Use preferred kernel type

This patch "uint16_t" type instead of "u16" type was used.
checkpatch.pl issue.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: olpc_dcon: Remove multiple blank lines
Aybuke Ozdemir [Fri, 16 Oct 2015 18:51:43 +0000 (21:51 +0300)]
Staging: olpc_dcon: Remove multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: r8723au: replace NULL and zero comparison tests with ! operator
Alison Schofield [Fri, 16 Oct 2015 18:46:29 +0000 (11:46 -0700)]
staging: r8723au: replace NULL and zero comparison tests with ! operator

Replace explicit NULL comparison and zero comparison test with ! operator
to simplify code.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: dgap: Remove unnecessary test expression
Shivani Bhardwaj [Fri, 16 Oct 2015 16:39:57 +0000 (22:09 +0530)]
Staging: dgap: Remove unnecessary test expression

struct bd is already NULL tested so, any further NULL checks should be
removed.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: gdx724x: gdm_mux: Remove explicit cast
Shivani Bhardwaj [Fri, 16 Oct 2015 15:26:22 +0000 (20:56 +0530)]
Staging: gdx724x: gdm_mux: Remove explicit cast

Compiler can typecast variables implicitly so, explicit type cast is not
required and should be removed.
Semantic patch used:

@@
type T;
T e;
identifier x;
@@

* T x = (T)e;

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: media: lirc: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:10:08 +0000 (13:40 +0530)]
staging: media: lirc: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: media: davinci_vpfe: Remove useless intialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:11:30 +0000 (13:41 +0530)]
staging: media: davinci_vpfe: Remove useless intialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: panel: Prefer using BIT Macro
Amitoj Kaur Chawla [Fri, 16 Oct 2015 16:41:36 +0000 (22:11 +0530)]
staging: panel: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro

The semantic patch used to find this is:
@@ int g; @@

-(1 << g)
+BIT(g)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: skein: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:14:20 +0000 (13:44 +0530)]
staging: skein: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: Prefer using BIT Macro
Amitoj Kaur Chawla [Fri, 16 Oct 2015 16:43:29 +0000 (22:13 +0530)]
staging: vt6655: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro

The semantic patch used to find this is:
@@ int g; @@

-(1 << g)
+BIT(g)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6656: Prefer using BIT Macro
Amitoj Kaur Chawla [Fri, 16 Oct 2015 16:42:35 +0000 (22:12 +0530)]
staging: vt6656: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro

The semantic patch used to find this is:
@@ int g; @@

-(1 << g)
+BIT(g)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: Remove boolean comparisons
Luis de Bethencourt [Thu, 15 Oct 2015 12:31:11 +0000 (13:31 +0100)]
staging: vt6655: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6656: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:17:00 +0000 (13:47 +0530)]
staging: vt6656: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:15:39 +0000 (13:45 +0530)]
staging: vt6655: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: amso1100: Prefer using BIT Macro
Amitoj Kaur Chawla [Fri, 16 Oct 2015 16:40:25 +0000 (22:10 +0530)]
staging: rdma: amso1100: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro

The semantic patch used to find this is:
@@ int g; @@

-(1 << g)
+BIT(g)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: hfi1: Prefer using BIT Macro
Amitoj Kaur Chawla [Fri, 16 Oct 2015 16:39:08 +0000 (22:09 +0530)]
staging: rdma: hfi1: Prefer using BIT Macro

Replace bit shifting on 1 with the BIT(x) Macro

The semantic patch used to find this is:
@@ int g; @@

-(1 << g)
+BIT(g)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: hfi1: delete unneeded tabs in conditional statement block
Alison Schofield [Fri, 16 Oct 2015 16:06:52 +0000 (09:06 -0700)]
staging: rdma: hfi1: delete unneeded tabs in conditional statement block

Delete unneeded tabs to indent statement block correctly at (8, 16).
checkpatch.pl:
WARNING: suspect code indent for conditional statements (8, 24)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: rdma: mad: Remove explicit cast
Shivani Bhardwaj [Thu, 15 Oct 2015 09:44:41 +0000 (15:14 +0530)]
Staging: rdma: mad: Remove explicit cast

Explicit type casting is not required as compiler can type cast
variables implicitly. Therefore, it should be removed.
Semantic patch used:
@@
type T;
T e;
identifier x;
@@

* T x = (T)e;

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: ipath: ipath_eeprom: Remove useless intialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:20:56 +0000 (13:50 +0530)]
staging: rdma: ipath: ipath_eeprom: Remove useless intialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: ipath: ipath_init_chip: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:22:08 +0000 (13:52 +0530)]
staging: rdma: ipath: ipath_init_chip: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: hfi1: diag: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:23:23 +0000 (13:53 +0530)]
staging: rdma: hfi1: diag: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: hfi1: sysfs: Remove useless initialisation
Amitoj Kaur Chawla [Thu, 15 Oct 2015 08:24:35 +0000 (13:54 +0530)]
staging: rdma: hfi1: sysfs: Remove useless initialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: Remove useless intialisation
Amitoj Kaur Chawla [Wed, 14 Oct 2015 21:52:22 +0000 (03:22 +0530)]
staging: unisys: Remove useless intialisation

Remove intialisation of a variable that is immediately reassigned.

The semantic patch used to find this is:

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: no need to track open count
Tim Sell [Wed, 14 Oct 2015 13:45:10 +0000 (09:45 -0400)]
staging: unisys: visorinput: no need to track open count

evdev_open_device() and evdev_close_device() (in evdev.c) already track
the open count under lock, and will only call visorinput_open() on the
first open and visorinput_close() on the last close.  So this patch
removes the unnessary logic from visorinput, and the now-unused counter
from the struct.

Signed-off-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: fix comment format
Tim Sell [Fri, 16 Oct 2015 14:06:47 +0000 (10:06 -0400)]
staging: unisys: visorinput: fix comment format

Fix the multi-line comment formatting in visorinput.c.

Signed-off-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>