sctp: add routing output fallback
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Wed, 2 Sep 2015 19:20:22 +0000 (16:20 -0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Sep 2015 22:43:05 +0000 (15:43 -0700)
commit410f03831c0768f2b1850d28ba697b167ddcb89b
treee9cc4151a252deba27e10e2ff06a2bd437a80b07
parentd82f0f1fc8a4f214a50c9dfc64e3896f9894afb7
sctp: add routing output fallback

Commit 0ca50d12fe46 added a restriction that the address must belong to
the output interface, so that sctp will use the right interface even
when using secondary addresses.

But it breaks IPVS setups, on which people is used to attach VIP
addresses to loopback interface on real servers. It's preferred to
attach to the interface actually in use, but it's a very common setup
and that used to work.

This patch then saves the first routing good result, even if it would be
going out through an interface that doesn't have that address. If no
better hit found, it's then used. This effectively restores the original
behavior if no better interface could be found.

Fixes: 0ca50d12fe46 ("sctp: fix src address selection if using secondary addresses")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/protocol.c