From 0e58156d700ac45fd5f0f90698a13233b1fe4c44 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Wed, 24 Apr 2019 17:21:40 -0700 Subject: [PATCH] tipc: remove rcu_read_unlock() left in tipc_udp_recv() I forgot to remove one rcu_read_unlock() before a return statement. Joy of mixing goto and return styles in a function :) Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot Signed-off-by: David S. Miller --- net/tipc/udp_media.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 7413cbc9b638..0884a1b8ad12 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb) if (b && test_bit(0, &b->up)) { tipc_rcv(sock_net(sk), skb, b); - rcu_read_unlock(); return 0; } -- 2.30.2