From 3eec4faddc92c8347d8cdc616aad4e3906ace186 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Thu, 8 Mar 2018 14:05:41 +0100 Subject: [PATCH] mfd: sm501: Improve a size determination in two functions Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Lee Jones --- drivers/mfd/sm501.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 7298d6b571a1..4f4957ea8fa3 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1383,7 +1383,7 @@ static int sm501_plat_probe(struct platform_device *dev) struct sm501_devdata *sm; int ret; - sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL); + sm = kzalloc(sizeof(*sm), GFP_KERNEL); if (sm == NULL) { ret = -ENOMEM; goto err1; @@ -1572,7 +1572,7 @@ static int sm501_pci_probe(struct pci_dev *dev, struct sm501_devdata *sm; int err; - sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL); + sm = kzalloc(sizeof(*sm), GFP_KERNEL); if (sm == NULL) { err = -ENOMEM; goto err1; -- 2.30.2