From 50d60c6322f14e32bc11635732c54db1447fd3f5 Mon Sep 17 00:00:00 2001 From: Fengguang Wu Date: Fri, 11 Oct 2013 23:30:26 +0800 Subject: [PATCH] wcn36xx: fix coccinelle warnings drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 106 /c/kernel-tests/src/i386/drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 148 This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Generated by: coccinelle/api/simple_open.cocci CC: Eugene Krasnikov CC: John W. Linville Signed-off-by: Fengguang Wu Signed-off-by: John W. Linville --- drivers/net/wireless/ath/wcn36xx/debug.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/debug.c b/drivers/net/wireless/ath/wcn36xx/debug.c index 682bcd650f70..5b84f7ae0b1e 100644 --- a/drivers/net/wireless/ath/wcn36xx/debug.c +++ b/drivers/net/wireless/ath/wcn36xx/debug.c @@ -24,13 +24,6 @@ #ifdef CONFIG_WCN36XX_DEBUGFS -static int wcn36xx_debugfs_open(struct inode *inode, struct file *file) -{ - file->private_data = inode->i_private; - - return 0; -} - static ssize_t read_file_bool_bmps(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) { @@ -103,7 +96,7 @@ static ssize_t write_file_bool_bmps(struct file *file, } static const struct file_operations fops_wcn36xx_bmps = { - .open = wcn36xx_debugfs_open, + .open = simple_open, .read = read_file_bool_bmps, .write = write_file_bool_bmps, }; @@ -145,7 +138,7 @@ static ssize_t write_file_dump(struct file *file, } static const struct file_operations fops_wcn36xx_dump = { - .open = wcn36xx_debugfs_open, + .open = simple_open, .write = write_file_dump, }; -- 2.30.2