From 5f61d9517f17069dbedb94aa71034f0a22e014ef Mon Sep 17 00:00:00 2001 From: Andy Shevchenko Date: Sun, 28 Apr 2019 20:19:06 +0300 Subject: [PATCH] pinctrl: intel: Increase readability of intel_gpio_update_pad_mode() We better to use usual pattern for read-modify-update, than doing some operations in definition block. No functional change. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/intel/pinctrl-intel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 1c85cc807a8f..d7acbb79cdf7 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1555,10 +1555,12 @@ intel_gpio_is_requested(struct gpio_chip *chip, int base, unsigned int size) static u32 intel_gpio_update_pad_mode(void __iomem *hostown, u32 mask, u32 value) { - u32 curr = readl(hostown); - u32 updated = (curr & ~mask) | (value & mask); + u32 curr, updated; + curr = readl(hostown); + updated = (curr & ~mask) | (value & mask); writel(updated, hostown); + return curr; } -- 2.30.2