From 6edf10173a1feb1078f2fc8c655baf9614e83493 Mon Sep 17 00:00:00 2001 From: Elad Raz Date: Sun, 23 Oct 2016 17:43:05 +0200 Subject: [PATCH] devlink: Prevent port_type_set() callback when it's not needed When a port_type_set() is been called and the new port type set is the same as the old one, just return success. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller --- net/core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index 1b5063088f1a..d2fd736de6a2 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -608,6 +608,8 @@ static int devlink_port_type_set(struct devlink *devlink, if (devlink->ops && devlink->ops->port_type_set) { if (port_type == DEVLINK_PORT_TYPE_NOTSET) return -EINVAL; + if (port_type == devlink_port->type) + return 0; err = devlink->ops->port_type_set(devlink_port, port_type); if (err) return err; -- 2.30.2