From 72c5e59f63ceaa604936b1693ba8c4b6cc2b114d Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 21 Aug 2014 11:09:27 -0500 Subject: [PATCH] pnfs/blocklayout: improve GETDEVICEINFO error reporting Tell userspace what stage of GETDEVICEINFO failed so that there is a chance to debug it, especially with the userspace daemon clusterf***k in the block layout driver. Signed-off-by: Christoph Hellwig Signed-off-by: Trond Myklebust --- fs/nfs/blocklayout/blocklayoutdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c index 04303b5c9361..63f77925aa87 100644 --- a/fs/nfs/blocklayout/blocklayoutdev.c +++ b/fs/nfs/blocklayout/blocklayoutdev.c @@ -150,7 +150,7 @@ nfs4_blk_decode_device(struct nfs_server *server, remove_wait_queue(&nn->bl_wq, &wq); if (reply->status != BL_DEVICE_REQUEST_PROC) { - dprintk("%s failed to open device: %d\n", + printk(KERN_WARNING "%s failed to decode device: %d\n", __func__, reply->status); rv = ERR_PTR(-EINVAL); goto out; @@ -159,7 +159,8 @@ nfs4_blk_decode_device(struct nfs_server *server, bd = blkdev_get_by_dev(MKDEV(reply->major, reply->minor), FMODE_READ, NULL); if (IS_ERR(bd)) { - dprintk("%s failed to open device : %ld\n", __func__, + printk(KERN_WARNING "%s failed to open device %d:%d (%ld)\n", + __func__, reply->major, reply->minor, PTR_ERR(bd)); rv = ERR_CAST(bd); goto out; -- 2.30.2