From 72e2fe38eac2dbf258d4295d75f78b123dd5b823 Mon Sep 17 00:00:00 2001 From: "Steven Rostedt (Red Hat)" Date: Thu, 5 Jun 2014 20:35:30 -0400 Subject: [PATCH] tracing: Convert stddev into u64 in tracepoint benchmark I've been told that do_div() expects an unsigned 64 bit number, and is undefined if a signed is used. This gave a warning on the MIPS build. I'm not sure if a signed 64 bit dividend is really an issue or not, but the calculation this is used for is standard deviation, and that isn't going to be negative. We can just convert it to unsigned and be safe. Reported-by: David Daney Signed-off-by: Steven Rostedt --- kernel/trace/trace_benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_benchmark.c b/kernel/trace/trace_benchmark.c index a10adc7095cd..8bd3365a65b2 100644 --- a/kernel/trace/trace_benchmark.c +++ b/kernel/trace/trace_benchmark.c @@ -33,7 +33,7 @@ static void trace_do_benchmark(void) u64 start; u64 stop; u64 delta; - s64 stddev; + u64 stddev; u64 seed; u64 last_seed; unsigned int avg; -- 2.30.2