From 958cbf5f45d1e417751872a246ad04ab4980ee6e Mon Sep 17 00:00:00 2001 From: Henrique de Moraes Holschuh Date: Sat, 2 May 2020 23:05:03 -0300 Subject: [PATCH] fping: install fping SUID root fping requires either root or CAP_NET_PING to work, otherwise it is useless. Use INSTALL_SUID so that fping will be setuid root, and thus it will be usable by non-root users. fping knows to drop root priviledges after it parses the command line and creates the ping socket. You actually get a lot less code running as root when you make it setuid root and run it from an unprivileged user. This is the same way net/iputils already handles "ping", which has the same requirements. Signed-off-by: Henrique de Moraes Holschuh --- net/fping/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/fping/Makefile b/net/fping/Makefile index 34bfdd3be2..1f777126df 100644 --- a/net/fping/Makefile +++ b/net/fping/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=fping PKG_VERSION:=4.2 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=https://fping.org/dist/ @@ -46,7 +46,7 @@ CONFIGURE_ARGS+= \ define Package/fping/install $(INSTALL_DIR) $(1)/usr/bin - $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/sbin/fping $(1)/usr/bin/ + $(INSTALL_SUID) $(PKG_INSTALL_DIR)/usr/sbin/fping $(1)/usr/bin/ endef $(eval $(call BuildPackage,fping)) -- 2.30.2