From a4b3996aeebbaafd2682f4db06bb5659e1653da7 Mon Sep 17 00:00:00 2001 From: Pixel Ding Date: Wed, 18 Apr 2018 04:33:26 -0400 Subject: [PATCH] drm/scheduler: always put last_sched fence in entity_fini MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fix the potential memleak since scheduler main thread always hold one last_sched fence. Signed-off-by: Pixel Ding Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 44d21981bf3b..4968867da7a6 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -276,10 +276,10 @@ void drm_sched_entity_cleanup(struct drm_gpu_scheduler *sched, else if (r) DRM_ERROR("fence add callback failed (%d)\n", r); } - - dma_fence_put(entity->last_scheduled); - entity->last_scheduled = NULL; } + + dma_fence_put(entity->last_scheduled); + entity->last_scheduled = NULL; } EXPORT_SYMBOL(drm_sched_entity_cleanup); -- 2.30.2