From c45974d0a32498810f305cb26746f45045b38008 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Oever=20Gonz=C3=A1lez?= Date: Sat, 31 Aug 2019 23:02:04 -0600 Subject: [PATCH] samba4: remove double quotes for renice MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The double quote thells the shell that the list returned from `pidof` is a single argument, therefore, `renice` will cry about a malformed input. With this commit, `renice` will be applied correctly to all the returned PIDs from `pidof`. The output of `renice` for the quoted list is as follows: `renice: invalid number '6592 6587 6586 6574'` `renice` does not show and does apply the nice value if the list is unquoted. Signed-off-by: Oever González Signed-off-by: Jan Pavlinec --- net/samba4/files/samba.init | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/samba4/files/samba.init b/net/samba4/files/samba.init index d7eed562aa..39686e6cd4 100644 --- a/net/samba4/files/samba.init +++ b/net/samba4/files/samba.init @@ -211,9 +211,9 @@ start_service() { fi # lower priority using renice (if found) if [ -x /usr/bin/renice ]; then - [ -x /usr/sbin/samba ] && renice -n 2 "$(pidof samba)" - [ -x /usr/sbin/smbd ] && renice -n 2 "$(pidof smbd)" - [ -x /usr/sbin/nmbd ] && renice -n 2 "$(pidof nmbd)" - [ -x /usr/sbin/winbindd ] && renice -n 2 "$(pidof winbindd)" + [ -x /usr/sbin/samba ] && renice -n 2 $(pidof samba) + [ -x /usr/sbin/smbd ] && renice -n 2 $(pidof smbd) + [ -x /usr/sbin/nmbd ] && renice -n 2 $(pidof nmbd) + [ -x /usr/sbin/winbindd ] && renice -n 2 $(pidof winbindd) fi } -- 2.30.2