From d484700a36952c6675aa47dec4d7a536929aa922 Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Tue, 4 Mar 2014 12:31:24 +0100 Subject: [PATCH] of: Warn if of_graph_parse_endpoint is called with the root node If of_graph_parse_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabel Acked-by: Tomi Valkeinen Acked-by: Mauro Carvalho Chehab Acked-by: Sylwester Nawrocki --- drivers/of/base.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index 715144af3a83..fd4b9c2eaa15 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -1996,6 +1996,9 @@ int of_graph_parse_endpoint(const struct device_node *node, { struct device_node *port_node = of_get_parent(node); + WARN_ONCE(!port_node, "%s(): endpoint %s has no parent node\n", + __func__, node->full_name); + memset(endpoint, 0, sizeof(*endpoint)); endpoint->local_node = node; -- 2.30.2