From d547ecdc1fc1eb5e9caf678d2f1c02cf3d77cbe7 Mon Sep 17 00:00:00 2001 From: Yonglong Liu Date: Thu, 13 Jun 2019 17:12:28 +0800 Subject: [PATCH] net: hns3: free irq when exit from abnormal branch In hns3_nic_init_irq(), if request irq fail at index i, the function return directly without releasing irq resources that already requested, and nowhere else will release them. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 66d733b130b4..73de4b06ba4d 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -143,6 +143,7 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv) if (ret) { netdev_err(priv->netdev, "request irq(%d) fail\n", tqp_vectors->vector_irq); + hns3_nic_uninit_irq(priv); return ret; } -- 2.30.2