From f1b298103e141e70616a6f69bec922c669a2732f Mon Sep 17 00:00:00 2001 From: Kamil Konieczny Date: Thu, 18 Jan 2018 19:34:03 +0100 Subject: [PATCH] crypto: bfin_crc - Add empty hash export and import Crypto framework requires export/import in async hash. If driver do not implement them, wrapper functions in framework will be used, and it will cause error during ahash alg registration (unless one disables crypto internal tests). To make change in framework and expose this requirement, I will remove wrappers from crypto/ahash.c , but this can broke code which depends on them. Add empty hash export and import, with the same behaviour as in framework and expose this directly in driver. This can also prevent OOPS when config option in Cryptographic API 'Disable run-time self tests' will be enabled. Signed-off-by: Kamil Konieczny Signed-off-by: Herbert Xu --- drivers/crypto/bfin_crc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c index bfbf8bf77f03..5ece3240531e 100644 --- a/drivers/crypto/bfin_crc.c +++ b/drivers/crypto/bfin_crc.c @@ -450,6 +450,16 @@ static int bfin_crypto_crc_digest(struct ahash_request *req) return bfin_crypto_crc_finup(req); } +static int bfin_crypto_crc_noimport(struct ahash_request *req, const void *in) +{ + return -ENOSYS; +} + +static int bfin_crypto_crc_noexport(struct ahash_request *req, void *out) +{ + return -ENOSYS; +} + static int bfin_crypto_crc_setkey(struct crypto_ahash *tfm, const u8 *key, unsigned int keylen) { @@ -487,6 +497,8 @@ static struct ahash_alg algs = { .final = bfin_crypto_crc_final, .finup = bfin_crypto_crc_finup, .digest = bfin_crypto_crc_digest, + .export = bfin_crypto_crc_noexport, + .import = bfin_crypto_crc_noimport, .setkey = bfin_crypto_crc_setkey, .halg.digestsize = CHKSUM_DIGEST_SIZE, .halg.base = { -- 2.30.2