From f3f760314afcb8522d2349b970b065589c5c8e48 Mon Sep 17 00:00:00 2001 From: David Howells Date: Thu, 25 Sep 2014 14:34:41 +0100 Subject: [PATCH] NFS: Fabricate fscache server index key correctly When fabricating a server index key for fscache, we should clear the index key buffer before starting to fill it in, not in the middle. Reported-by: James Pearson Signed-off-by: David Howells Acked-by: Steve Dickson Signed-off-by: Trond Myklebust --- fs/nfs/fscache-index.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/fscache-index.c b/fs/nfs/fscache-index.c index 7cf2c4699b08..777b055063f6 100644 --- a/fs/nfs/fscache-index.c +++ b/fs/nfs/fscache-index.c @@ -74,11 +74,10 @@ static uint16_t nfs_server_get_key(const void *cookie_netfs_data, struct nfs_server_key *key = buffer; uint16_t len = sizeof(struct nfs_server_key); + memset(key, 0, len); key->nfsversion = clp->rpc_ops->version; key->family = clp->cl_addr.ss_family; - memset(key, 0, len); - switch (clp->cl_addr.ss_family) { case AF_INET: key->port = sin->sin_port; -- 2.30.2